feat: security-harden the RPi camera plugin and reorganize into delivery/streaming/observability#14
Merged
Conversation
…r HTTP status handling
Co-authored-by: Copilot <copilot@github.com>
…time Type ImageProperties.capture_time as AwareDatetime so naive values are rejected, and convert to UTC in serialize_datetime_with_z so non-UTC offsets emit a real 'Z' timestamp instead of a bare offset.
Address code-review findings on the test suite: - backend/test_client: fix zero-arg build_device_assertion stub that passed only via the caught TypeError, not the intended ValueError - camera/test_manager: relocate check_stream_duration tests into their class and assert the logged message in test_logs_runtime_error - streaming/test_preview_pipeline: yield distinct encoder instances so the restart assertion verifies a fresh encoder at the new bitrate - integration/test_setup: assert the probe fetches the normalized URL - pairing/test_flow: drop dead get_responses payload - workers/test_preview_sleeper: correct stale autouse-fixture comment - backend/test_contract_adapters: assert required EXIF tags, not truthiness - streaming/test_stream: drop always-skipping non-YouTube-modes test Also sanitize the DELETE /streams/youtube 500 via client_error_detail so internal RuntimeError text no longer leaks to clients, matching the captures/hls error paths; test flipped to assert the message is hidden.
Weaker subset of test_active_stream_returns_contract_view in tests/unit/backend/test_contract_adapters.py.
…duplicates test_single_key_string now feeds a bare string so it covers the JSON-decode comma-split fallback instead of duplicating test_valid_json_array. Remove two pure model_validate_json(model_dump_json()) round-trips that only exercised Pydantic serialization; validator coverage lives in the reject_* tests.
get_state() is a one-line getter; asserting it returns self.state tests nothing. Keep the reset_state coverage.
- Drop Dockerfile.mediamtx; the pinned mediamtx-ffmpeg image already ships busybox wget for the healthcheck, so use it directly in compose and remove the now-dead paths-filter entry from the security workflow. - Move renovate.json and codecov.yml under .github/ to declutter the root. - Trim renovate.json: drop the default-on pep621 block and the pinDigests keys already implied by config:best-practices.
Resolve conflicts in favor of dev (feature-first hardening branch): PR #9's pairing rework and dev's overlap the same files, dev is the superset. Adopt main's renovate action bumps (checkout df4cb1c, setup-uv v8.2.0) across all workflows and the pyjwt 2.13.0 / pydantic-settings 2.14.2 security bumps. Drop -X ours collateral: dead __all__ in pairing service.py and duplicate _parse_list_env in settings.py.
simonvanlierde
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
- middleware: salt+HMAC rate-limit bucket keys (CodeQL weak-hash on sensitive data) - backend: drop redundant bare ... after property docstring - tracing: replace bare ... protocol bodies with docstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production security-hardening pass plus a feature-first reorganization.
166 files; the bulk is defensive work backed by tests, plus a no-behavior-change module reshuffle. Details in CHANGELOG.md under v0.4.0.
Highlights
Security
DEBUG=truein prod; reveal local API key on demand instead of embedding in HTMLRefactor
image_sinks/upload→delivery,media→camera/streaming,system→observabilityFixes
Testing
Suite green after follow-up fixes; net LOC down from dead-code and duplicate-test cleanup.