Skip to content

Don't run the ffi_qaqc example when checking package#109

Merged
wilsonsj100 merged 2 commits intomainfrom
eff-it-disabling
Sep 8, 2025
Merged

Don't run the ffi_qaqc example when checking package#109
wilsonsj100 merged 2 commits intomainfrom
eff-it-disabling

Conversation

@bpbond
Copy link
Copy Markdown
Member

@bpbond bpbond commented Sep 4, 2025

To address #107 (comment)

@bpbond bpbond requested a review from wilsonsj100 September 4, 2025 12:44
@wilsonsj100
Copy link
Copy Markdown
Collaborator

Do we want to accept this if it's failing one of the checks?

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Sep 4, 2025

Definitely not! Hang on.

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Sep 4, 2025

This is weird, and not related to my changes in the PR. It's failing only for the "devel" (in-development) version of R, with some weird ll() function deep inside broom or its dependencies. Ugh. I'm going to wait a few hours and try re-running it.

@wilsonsj100
Copy link
Copy Markdown
Collaborator

Hmmmm - okay thank you for taking a look! Hopefully rerunning in a bit will help.

@bpbond
Copy link
Copy Markdown
Member Author

bpbond commented Sep 6, 2025

Yay, check problem fixed itself! @wilsonsj100

@wilsonsj100 wilsonsj100 merged commit 6a88763 into main Sep 8, 2025
8 of 9 checks passed
@wilsonsj100 wilsonsj100 deleted the eff-it-disabling branch September 8, 2025 13:39
@wilsonsj100
Copy link
Copy Markdown
Collaborator

Yeah! I saw that it seemed okay, so I resubmitted to CRAN. Let's keep our fingers crossed that we will be all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants