Skip to content

Port improved item model fix and documentation to 1.21.11 (#3565)#3581

Merged
douira merged 1 commit intoCaffeineMC:1.21.11/stablefrom
Argon4W:1.21.11/stable
Apr 8, 2026
Merged

Port improved item model fix and documentation to 1.21.11 (#3565)#3581
douira merged 1 commit intoCaffeineMC:1.21.11/stablefrom
Argon4W:1.21.11/stable

Conversation

@Argon4W
Copy link
Copy Markdown
Contributor

@Argon4W Argon4W commented Apr 7, 2026

No description provided.

@Argon4W Argon4W marked this pull request as ready for review April 7, 2026 02:13
@douira
Copy link
Copy Markdown
Contributor

douira commented Apr 7, 2026

This user reports that the PR crashes on neoforge: #3583 (comment)

@Argon4W
Copy link
Copy Markdown
Contributor Author

Argon4W commented Apr 8, 2026

This user reports that the PR crashes on neoforge: #3583 (comment)

I just tested and the neoforge version did not crash. Has the user turned off the enableB3DVValidationLayer?(#3253) The validation layer is on by default in dev environment.

@douira
Copy link
Copy Markdown
Contributor

douira commented Apr 8, 2026

Yeah I don't know what exactly their crash was. I'll validate it on my own and merge if it doesn't break.

@Argon4W
Copy link
Copy Markdown
Contributor Author

Argon4W commented Apr 8, 2026

Okay

@douira douira merged commit 284d831 into CaffeineMC:1.21.11/stable Apr 8, 2026
1 check passed
@douira
Copy link
Copy Markdown
Contributor

douira commented Apr 8, 2026

It crashed for me but I was able to fix that by doing a gradle clean. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants