Skip to content

fix(a11y): associate search form labels with their inputs #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NakuRei wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

fix(a11y): associate search form labels with their inputs #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion layouts/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h2 class="article-subtitle">{{ T "notFound.subtitle" }}</h2>
{{- with $searchPage -}}
<form action="{{ $searchPage.RelPermalink }}" class="search-form widget" {{ with .OutputFormats.Get "json" -}}data-json="{{ .RelPermalink }}" {{- end }}>
<p>
<label>{{ T "search.title" }}</label>
<label for="searchInput">{{ T "search.title" }}</label>
<input id="searchInput" name="keyword" required placeholder="{{ T `search.placeholder` }}" />

<button title="{{ T `search.title` }}">
Expand Down
4 changes: 2 additions & 2 deletions layouts/_partials/widget/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
{{- $searchPage := index $query 0 -}}
<form action="{{ $searchPage.RelPermalink }}" class="search-form widget" {{ with .OutputFormats.Get "json" -}}data-json="{{ .RelPermalink }}" {{- end }}>
<p>
<label>{{ T "search.title" }}</label>
<input name="keyword" required placeholder="{{ T `search.placeholder` }}" />
<label for="search-widget-input">{{ T "search.title" }}</label>
<input id="search-widget-input" name="keyword" required placeholder="{{ T `search.placeholder` }}" />

<button title="{{ T `search.title` }}">
{{ partial "helper/icon" "search" }}
Expand Down
4 changes: 2 additions & 2 deletions layouts/page/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
{{ define "main" }}
<form action="{{ .RelPermalink }}" class="search-form"{{ with .OutputFormats.Get "json" -}} data-json="{{ .RelPermalink }}"{{- end }}>
<p>
<label>{{ T "search.title" }}</label>
<input name="keyword" placeholder="{{ T `search.placeholder` }}" />
<label for="search-page-input">{{ T "search.title" }}</label>
<input id="search-page-input" name="keyword" placeholder="{{ T `search.placeholder` }}" />
</p>

<button title="{{ T `search.title` }}">
Expand Down