fix(#1036): eliminate billing-cycle date drift with date-fns - #1111
Merged
Calebux merged 1 commit intoJul 26, 2026
Merged
Conversation
- Add weekly and annual cases to calculateNextRenewal using addWeeks/addYears - Extend billing_cycle union type to include 'weekly' | 'annual' (was silently falling through to default, returning unchanged date on every renewal) - Add property-style tests covering month-end clamping (Jan 31 -> Feb 28/29), quarterly end clamping (Mar 31 -> Jun 30), and no-drift assertions over 12 monthly and 52 weekly iterations - Fix misleading test description 'add 365 days' -> calendar-aware addYears
|
Hey @alexatsejames-alt! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Briefly describe what this PR does.
Related Issue
Closes #
Test Plan
Screenshots (if applicable)
Checklist
Reminder billing-cycle date drift across intervals #1036