fix: Implement comprehensive CSV injection security protection - #1132
Merged
Calebux merged 1 commit intoJul 26, 2026
Merged
Conversation
- Add formula injection validation on CSV import to reject malicious rows - Add sanitization on all CSV exports (backend and client) - Protect against cells starting with =, +, -, @, tab, or carriage return - Dangerous cells are prefixed with single quote to force text interpretation Changes: - csv-import-service.ts: Added detectFormulaInjection() and validateCellSafety() - renewal-history.service.ts: Added sanitizeCSVCell() for export protection - privacy-metrics.ts: Added sanitizeCSVCell() for export protection - csv-utils.ts: Enhanced with security comments and sanitization - Added comprehensive test suites for import and export security Tests: - csv-import-service.test.ts: 50+ test cases for import validation - renewal-history-csv-export.test.ts: Export sanitization tests - privacy-metrics-csv-export.test.ts: Privacy metrics export tests - csv-utils.test.ts: Client-side protection tests Security: - Prevents DDE (Dynamic Data Exchange) attacks - Prevents hyperlink injection and data exfiltration - Prevents command execution via formula injection - Defense-in-depth: protection at both import and export layers Documentation: - CSV_INJECTION_SECURITY_FIX.md: Comprehensive security documentation Resolves CSV injection vulnerability issue
|
@coderolisa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1034
Changes:
Tests:
Security:
Documentation:
Resolves CSV injection vulnerability issue
Description
Test Plan
Screenshots (if applicable)
Checklist