Process @{namespace}::EXPORT correctly#2896
Open
blindpirate wants to merge 3 commits intoCamelcade:masterfrom
Open
Process @{namespace}::EXPORT correctly#2896blindpirate wants to merge 3 commits intoCamelcade:masterfrom
@{namespace}::EXPORT correctly#2896blindpirate wants to merge 3 commits intoCamelcade:masterfrom
Conversation
ae91dc4 to
f7c4f61
Compare
a3a0ff3 to
88b1bc7
Compare
Collaborator
|
Will be able to check this on the weekend, thank you. |
Collaborator
|
I would also recommend to run |
plugin/core/src/main/java/com/perl5/lang/perl/psi/mixins/PerlNamespaceDefinitionMixin.java
Fixed
Show fixed
Hide fixed
Contributor
Author
|
There is another corner case fixed in this PR, which was not supported before:: Though this |
56ff615 to
84d5d04
Compare
Collaborator
|
god, i can't look at my own code without tears after 7 years. but this is probably a good thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2494
Currently, only
@EXPORT = ...can be recognized. This PR adds support for@{namespace}::EXPORT = ....This is how it works: