Skip to content

fix: add time and size estimation below export buttons (#224) #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BMNTR wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add time and size estimation below export buttons (#224) #2050

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e25afc
fix: add time and size estimation below export buttons (#224)
BMNTR Jul 29, 2026
f8a48d4
fix: format long export time estimates in minutes and seconds
BMNTR Jul 29, 2026
1496e80
fix: add strict Number.isFinite guards for export size and time calcu…
BMNTR Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions apps/desktop/src/routes/editor/ExportPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,25 @@ export function ExportPage() {
</>
)}
</Button>
<Show when={renderEstimate()}>
{(est) => {
const sec = Math.max(
1,
Math.round(
Comment thread
BMNTR marked this conversation as resolved.
Outdated
(est().frameRenderTimeMs * est().totalFrames) / 1000,
),
);
const timeStr =
sec < 60
? `~${sec}s`
: `~${Math.floor(sec / 60)}m ${sec % 60}s`;
return (
<p class="text-xs text-gray-10 text-center mt-0.5">
Est. size: {est().estimatedSizeMb.toFixed(1)} MB • Est. time: {timeStr}
</p>
);
Comment thread
BMNTR marked this conversation as resolved.
Outdated
}}
</Show>
</div>
)}
</div>
Expand Down
18 changes: 17 additions & 1 deletion apps/desktop/src/routes/recordings-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,14 +374,30 @@ export default function () {
>
<IconCapUpload class="size-4" />
</TooltipIconButton>
<div class="flex absolute inset-0 justify-center items-center">
<div class="flex flex-col absolute inset-0 justify-center items-center gap-1">
<Button
variant="white"
size="sm"
onClick={() => save.mutate()}
>
Export
</Button>
<Show when={metadata.latest}>
{(metadata) => {
const sec = Math.ceil(
metadata().estimatedExportTime,
);
const timeStr =
sec < 60
? `~${sec}s`
: `~${Math.floor(sec / 60)}m ${sec % 60}s`;
return (
<span class="text-[10px] text-gray-200 font-medium bg-black/50 px-2 py-0.5 rounded backdrop-blur-sm">
Est. {metadata().size.toFixed(1)} MB • {timeStr}
</span>
);
Comment thread
BMNTR marked this conversation as resolved.
Outdated
}}
</Show>
</div>
</div>
<Show when={metadata.latest}>
Expand Down