Fix segfault with image overlay when restarting a room. - #1152
Merged
Conversation
ISSUE: When you have an image overlay command that cancels a layer AND another on the same layer that has `Loop -1`, restarting the room can cause a segfault. DIAGNOSIS: The exact issue was in `DisplayPersistingImageOverlays`; if there were two private datas and the first image overlay cleared the second one we ended up with no private data. But then `pObj = CueEvents.GetFirstPrivateData(cid);` would set `pObj` to null causing a segfault due to playing with deleted/undefiend memory. SOLUTION: Moved the proceeding to the next private data to the end of effect removing code.
mrimer
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE: When you have an image overlay command that cancels a layer AND another on the same layer that has
Loop -1, restarting the room can cause a segfault.DIAGNOSIS: The exact issue was in
DisplayPersistingImageOverlays; if there were two private datas and the first image overlay cleared the second one we ended up with no private data. But thenpObj = CueEvents.GetFirstPrivateData(cid);would setpObjto null causing a segfault due to playing with deleted/undefiend memory.SOLUTION: Moved the proceeding to the next private data to the end of effect removing code.
REFERENCE: https://forum.caravelgames.com/viewtopic.php?TopicID=47386