Add plain-text card art language index and language-aware unique card selection - #11572
Open
churrufli wants to merge 1 commit into
Open
Add plain-text card art language index and language-aware unique card selection#11572churrufli wants to merge 1 commit into
churrufli wants to merge 1 commit into
Conversation
churrufli
force-pushed
the
card-art-language-exceptions
branch
from
August 9, 2026 23:37
44b73fd to
1eab076
Compare
churrufli
force-pushed
the
card-art-language-exceptions
branch
from
August 10, 2026 00:08
1eab076 to
c6c0d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the approach from #11507 and follows up on the discussion started in #11560.
Instead of a generated bitmask index, this stores confirmed non-English printings in a plain text file (
forge-gui/res/languages/card-art-languages.txt, oneSET/CN=lang,langline per printing), generated byforge-gui/tools/updateCardArtLanguages.py. No bitmask, no changes to edition files,ImageFetcher/GuiDownloadFilteredCardImagestry the preferred language first when confirmed, falling back to today's default otherwise.res/languages/cardnames-*.txt), this new file will need to be kept up to date over time. I'm happy to integrate its generation into whatever process/script this project already uses to update those. Either way, the result is plain text and editable by hand if needed.One personal note to close: some time ago I helped with Forge's internationalization, (in the cardforge.org git) among other things. I still believe that opening the door to more languages is always a good thing for this project. I hope this gets some consideration, thank you all.