Skip to content

Enable full LTO in both workspaces #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marcin-Radecki wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable full LTO in both workspaces #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27133f4
Try enabling full LTO in both workspaces
Marcin-Radecki Aug 14, 2025
61f79f2
Merge branch 'main' into enable-lto
Marcin-Radecki Aug 29, 2025
7d0bc44
Merge branch 'main' into enable-lto
Marcin-Radecki Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,7 @@ shielder-setup = { path = "crates/shielder-setup" }
type-conversions = { path = "crates/type-conversions" }
transcript = { path = "crates/transcript" }
shielder-scheduler-common = { path = "crates/shielder-scheduler-common" }

#[profile.release]
lto = "fat"
Comment on lines +139 to +140

@coderabbitai coderabbitai Bot Sep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

LTO not actually enabled at the workspace: header is commented; setting is ignored.

Same issue as in tee: Cargo ignores lto outside a [profile.*] table.

Apply:

-#[profile.release]
-lto = "fat"
+[profile.release]
+lto = "fat"
🤖 Prompt for AI Agents 
In Cargo.toml around lines 139 to 140, the profile header is commented out so
the lto = "fat" setting is ignored; remove the leading '#' to make it an actual
profile table ([profile.release]) so Cargo applies the lto setting at this
manifest scope (if you intend workspace-wide settings, ensure this table is in
the workspace root Cargo.toml; otherwise place it in each package's Cargo.toml).


4 changes: 4 additions & 0 deletions tee/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ vsock = "0.5.1"
ecies-encryption-lib = { git = "https://github.com/Cardinal-Cryptography/ecies-encryption-lib", tag = "v0.2.0" }

# below dependencies contains a rev which is also used in tee/nix/flake.nix, which is far from ideal since one needs to bump it there as well

shielder-circuits = { git = "https://github.com/Cardinal-Cryptography/blanksquare-monorepo", rev = "8d17e23ee807e2f1b40b31ffba27c1276afdb81f" }
type-conversions = { git = "https://github.com/Cardinal-Cryptography/blanksquare-monorepo", rev = "8d17e23ee807e2f1b40b31ffba27c1276afdb81f" }
powers-of-tau = { git = "https://github.com/Cardinal-Cryptography/blanksquare-monorepo", rev = "8d17e23ee807e2f1b40b31ffba27c1276afdb81f" }

#[profile.release]
lto = "fat"
Comment on lines +48 to +49

@coderabbitai coderabbitai Bot Sep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

LTO not actually enabled: profile header is commented out.

#[profile.release] is a comment; lto = "fat" at top-level is ignored by Cargo. Net effect: no LTO.

Apply:

-#[profile.release]
-lto = "fat"
+[profile.release]
+lto = "fat"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#[profile.release]
lto = "fat"
[profile.release]
lto = "fat"
🤖 Prompt for AI Agents 
In tee/Cargo.toml around lines 48-49 the profile header is commented out
(`#[profile.release]`) so the `lto = "fat"` setting is at top-level and ignored;
to enable LTO change the commented header to a proper TOML table header
`[profile.release]` and place `lto = "fat"` (and any other profile keys) beneath
it so Cargo recognizes and applies LTO for release builds.

Loading