This repository was archived by the owner on Apr 11, 2025. It is now read-only.
Switch to PhantomJS - #137
Open
stewartyu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#136
Current Status
Right now, config is setup to set PhantomJS viewport settings, but it's not respecting it. You can see in the logging statement that the browser viewport height is 7188px even though the config explicitly set it to 600. You'll see that if you switch it back to Chrome, the viewport height will be correct and the tests will pass.
I used this as a basis: karma-runner/karma#438 (comment)
Todos
Impacted Areas
Steps to Reproduce
npm test