Fix PNTS section bounds validation - #1432
Open
atirna wants to merge 1 commit into
Open
Conversation
Assisted-by: Codex
Collaborator
|
Thanks @atirna for the PR! We still need a signed Contributor License Agreement from you in order to review your code. Once that is signed, we can put this on our review queue and take a look! |
Author
|
have submitted the CLA form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject PNTS tiles when the declared feature and batch table sections extend past the tile's
byteLength. The check uses a 64-bit aggregate before any section spans are created, covering both vulnerable paths.Issue number or link
Fixes #1425
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Testing plan
cmake --build build --target cesium-native-tests --parallel 4build/CesiumNativeTests/cesium-native-tests --test-case='Rejects PNTS sections that extend past the declared byte length'(1 test case, 8 assertions)clang-format --dry-run --Werroron the changed C++ source and test