Add ignore khr materials unlit option - #594
Closed
david-lively wants to merge 23 commits into
Closed
Conversation
david-lively
marked this pull request as ready for review
August 5, 2025 19:06
david-lively
marked this pull request as draft
August 5, 2025 19:23
…will be ignored everywhere
… contain lighting and other misc features needed by worker threads when creating a model.
removed whitespace
kring
reviewed
Aug 7, 2025
kring
left a comment
kring
left a comment
Member
There was a problem hiding this comment.
Looks good @david-lively! A few small comments below.
david-lively
marked this pull request as ready for review
August 8, 2025 17:52
Contributor
Author
|
Closing this PR in favor of a new one with a cleaner commit log. See #595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to override the
KHR_unlit_materialflag in a glTF 3DTileset.Author checklist
[ ] I have submitted a Contributor License Agreement (only needed once).CHANGES.mdwith a short summary of my change (for user-facing changes).[ ] I have added or updated unit tests to ensure consistent code coverage as necessary.[ ] I have updated the documentation as necessary.Testing plan
Load a 3DTileset that uses
KHR_material_unlitflag. Observe that it is rendered using the unlit material. Toggle the checkbox and observe that it is rendered with default lighting.