chassis: dialog focus management, landmark fixes, reduced motion, skip link#464
Merged
Conversation
…p link Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0176ZYTwoV8V4So9SBTizc5X
ChBrain
force-pushed
the
chassis/a11y-dialogs-and-landmarks
branch
from
July 4, 2026 18:44
6fa5b8a to
110df72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessibility batch for the shared chassis:
role=dialog aria-modal=true) now actually manages focus: focuses the close button on open, traps Tab within the card, restores focus to the opener on close (WCAG 2.4.3 — previously keyboard/SR focus stayed behind the scrim).<main>:Book.astro's<main class="pb-spreads">→<div>(BaseLayout owns the page's main landmark).<body>, targeting<main id="content">.scrollIntoViewbehavior now respectprefers-reduced-motion; Shelf hover transform likewise.SELECT,contenteditable, and modified keys.Mark.astrodefaults toaria-hidden="true"(the brand SVGs contain live<text>glyphs that screen readers announced as stray letters); optionallabelprop emitsrole="img"+aria-labelinstead.aria-labelon generic elements (SiteHeaderlocation span,MnemonicStripdiv) — AT ignored these labels, so this is markup-validity cleanup with no information loss. (Visually-hidden text prefixes were tried and deliberately rejected: they violate the word-provenance contract incharacter-introduction.test.ts.)ChapterCardchapter namesh3→h2(fixes the h1→h3 skip on spec pages).Verification: build + unit + site/architecture/plays a11y groups green on the combined tree with #460.
🤖 Generated with Claude Code
https://claude.ai/code/session_0176ZYTwoV8V4So9SBTizc5X
Generated by Claude Code