Skip to content

chore: bump spec test version to v1.6.1 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lodekeeper-z wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: bump spec test version to v1.6.1 #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ pub fn build(b: *std.Build) void {
const options_spec_test_options = b.addOptions();
const option_spec_test_url = b.option([]const u8, "spec_test_url", "") orelse "https://github.com/ethereum/consensus-specs";
options_spec_test_options.addOption([]const u8, "spec_test_url", option_spec_test_url);
const option_spec_test_version = b.option([]const u8, "spec_test_version", "") orelse "v1.6.0-beta.2";
const option_spec_test_version = b.option([]const u8, "spec_test_version", "") orelse "v1.6.1";

@gemini-code-assist gemini-code-assist Bot Mar 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While updating the default spec_test_version is correct, this change appears to be incomplete. The file test/spec/version.txt is generated from this value and is used as a cache key for spec tests in CI. It still contains the old version (v1.6.0-beta.2).

Please regenerate test/spec/version.txt by running the appropriate build step (likely related to download_spec_tests) and include the updated file in this pull request to ensure CI uses the correct test vectors.

options_spec_test_options.addOption([]const u8, "spec_test_version", option_spec_test_version);
const option_spec_test_out_dir = b.option([]const u8, "spec_test_out_dir", "") orelse "test/spec/spec_tests";
options_spec_test_options.addOption([]const u8, "spec_test_out_dir", option_spec_test_out_dir);
Expand Down
2 changes: 1 addition & 1 deletion zbuild.zon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
.type = "string",
},
.spec_test_version = .{
.default = "v1.6.0-beta.2",
.default = "v1.6.1",
.type = "string",
},
.spec_test_out_dir = .{
Expand Down
Loading