refactor(api): port auth routes - #173
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
📝 WalkthroughWalkthroughThe four auth routes were migrated from class-based ChangesAuth route migration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@services/api/src/routes/routes.ts`:
- Around line 3-6: Update the route migration so the frontend auth and AMA
consumers retain compatible TypeScript exports until `#131` lands: either merge
the replacement API migration with this change or preserve the existing route
type exports from the reflection barrel. Ensure strict TypeScript consumers in
apps/website continue to typecheck while the defineRoute-based routes remain
supported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16508a07-2e97-4b08-a7bc-e207b58a2d0e
📒 Files selected for processing (7)
docs/roadmap/02-foundation.mdservices/api/src/routes/_types/routeTypes.tsservices/api/src/routes/auth/discord.tsservices/api/src/routes/auth/discordCallback.tsservices/api/src/routes/auth/logout.tsservices/api/src/routes/auth/me.tsservices/api/src/routes/routes.ts
💤 Files with no reviewable changes (1)
- services/api/src/routes/_types/routeTypes.ts
Closes #129
Summary by CodeRabbit
Authentication
Documentation