Skip to content

Make admin user password management idempotent.#1137

Merged
robin-checkmk merged 2 commits into
develfrom
feature/server-role-passwd-idempotence
Jul 10, 2026
Merged

Make admin user password management idempotent.#1137
robin-checkmk merged 2 commits into
develfrom
feature/server-role-passwd-idempotence

Conversation

@robin-checkmk

Copy link
Copy Markdown
Member

Pull request type

Try to limit your pull request to one type, submit multiple pull requests if needed.

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (describe what kind of change you performed):

What is the current behavior?

Describe the current behavior that you are modifying, or link to a relevant issue.

What is the new behavior?

Describe the behavior or changes that are being added by this PR.

  • Previously, the site admin password was rewritten on every run, breaking idempotence. Now the password is only updated, when it actually differs from the configured one.

Other information

Any other information that is important to this PR, e.g screenshots of how the component looks before and after the change.

@robin-checkmk robin-checkmk self-assigned this Jul 9, 2026
@github-actions github-actions Bot added the role:server This affects the server role label Jul 9, 2026
@robin-checkmk robin-checkmk marked this pull request as ready for review July 9, 2026 12:11

@kumaran-repo kumaran-repo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idempotency fix looks good.

@robin-checkmk robin-checkmk merged commit 307be0e into devel Jul 10, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

role:server This affects the server role

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants