Add lookup modules for activations#973
Merged
Merged
Conversation
06b8730 to
0cb85bf
Compare
Member
Author
|
While this is generally ready for review, the code needs a thorough going through and the integration tests are rather limited and might need an additional angle. Please review diligently. |
lgetwan
requested changes
Jan 15, 2026
lgetwan
left a comment
Contributor
There was a problem hiding this comment.
The actual code looks fine.
I just have an improvement suggestion for the integration tests.
1e36f32 to
fe01d49
Compare
7936443 to
1eea202
Compare
1eea202 to
2724f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Check the type of change your PR introduces:
What is the current behavior?
There are no lookup plugins for activations.
What is the new behavior?
There are lookup plugins for activations. One to list all running activations and one to look up a specific activation.
Other information