Skip to content

Add lookup modules for activations#973

Merged
robin-checkmk merged 1 commit into
develfrom
feature/activation-lookups-and-improvements
Feb 24, 2026
Merged

Add lookup modules for activations#973
robin-checkmk merged 1 commit into
develfrom
feature/activation-lookups-and-improvements

Conversation

@robin-checkmk

Copy link
Copy Markdown
Member

Pull request type

Try to limit your pull request to one type, submit multiple pull requests if needed.

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (describe what kind of change you performed):

What is the current behavior?

Describe the current behavior that you are modifying, or link to a relevant issue.

There are no lookup plugins for activations.

What is the new behavior?

Describe the behavior or changes that are being added by this PR.

There are lookup plugins for activations. One to list all running activations and one to look up a specific activation.

Other information

Any other information that is important to this PR, e.g screenshots of how the component looks before and after the change.

@robin-checkmk robin-checkmk self-assigned this Dec 31, 2025
@robin-checkmk robin-checkmk changed the title Add lookup modules for activations. Add lookup modules for activations Dec 31, 2025
@robin-checkmk robin-checkmk force-pushed the feature/activation-lookups-and-improvements branch from 06b8730 to 0cb85bf Compare December 31, 2025 16:10
@robin-checkmk robin-checkmk marked this pull request as ready for review December 31, 2025 16:34
@robin-checkmk

Copy link
Copy Markdown
Member Author

While this is generally ready for review, the code needs a thorough going through and the integration tests are rather limited and might need an additional angle. Please review diligently.

@lgetwan lgetwan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code looks fine.
I just have an improvement suggestion for the integration tests.

Comment thread plugins/lookup/activation.py Outdated
Comment thread tests/integration/targets/lookup_activation/tasks/test.yml
@robin-checkmk robin-checkmk force-pushed the feature/activation-lookups-and-improvements branch 4 times, most recently from 1e36f32 to fe01d49 Compare January 21, 2026 10:41
@robin-checkmk robin-checkmk force-pushed the feature/activation-lookups-and-improvements branch 3 times, most recently from 7936443 to 1eea202 Compare January 23, 2026 11:19
@robin-checkmk robin-checkmk force-pushed the feature/activation-lookups-and-improvements branch from 1eea202 to 2724f19 Compare January 23, 2026 11:28

@lgetwan lgetwan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, now!

@robin-checkmk robin-checkmk added lookup:activation This affects the lookup module 'activation'. lookup:activations This affects the lookup module 'activation'. labels Feb 2, 2026
@robin-checkmk robin-checkmk merged commit 65245be into devel Feb 24, 2026
34 checks passed
@robin-checkmk robin-checkmk deleted the feature/activation-lookups-and-improvements branch February 24, 2026 06:39
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lookup:activation This affects the lookup module 'activation'. lookup:activations This affects the lookup module 'activation'.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants