Skip to content

subsonic: accept native cover ids in getCoverArt #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loskutov wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

subsonic: accept native cover ids in getCoverArt #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion backend/src/routes/subsonic/playback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,15 @@ playbackRouter.all("/getCoverArt.view", wrap(async (req, res) => {

let coverUrl: string | null = null;

// Some clients pass native cover references directly as the id value
// (e.g. id=native:artists/<file>.jpg).
if (rawId.startsWith("native:")) {
coverUrl = rawId;
}

// Try album first (most common); ar- prefix skips album lookup since that ID is an artist ID.
// Falls through to artist/track as a cascade — clients may use any prefix for any entity.
if (!rawId.startsWith("ar-")) {
if (!coverUrl && !rawId.startsWith("ar-")) {
const album = await prisma.album.findUnique({
where: { id },
select: { coverUrl: true, userCoverUrl: true },
Expand Down
Loading