Skip to content

[CHIA-4363] Delete NFT Bulk Minting endpoints - #21298

Draft
Quexington wants to merge 1 commit into
mainfrom
quex.delete_nft_bulk_mint
Draft

[CHIA-4363] Delete NFT Bulk Minting endpoints#21298
Quexington wants to merge 1 commit into
mainfrom
quex.delete_nft_bulk_mint

Conversation

@Quexington

@Quexington Quexington commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Removes a public wallet RPC capability and large mint code paths; clients relying on nft_mint_bulk will break, though core single-mint behavior remains.

Overview
Removes NFT bulk minting from the wallet stack: the nft_mint_bulk RPC handler, client stub, and RPC metadata entry are deleted, along with mint_from_did and mint_from_xch on NFTWallet (intermediate-launcher chunked mint flows).

The entire test_nft_bulk_mint.py suite (~625 lines) is removed. nft_wallet.py import cleanup drops unused DID puzzle / singleton helpers tied to those paths.

Single-NFT minting (generate_new_nft, NFTMintNFTRequest) and other bulk operations (set_bulk_nft_did, bulk_transfer_nft, nft_set_did_bulk, nft_transfer_bulk) are unchanged.

Reviewed by Cursor Bugbot for commit a34e7ef. Bugbot is set up for automated code reviews on this repo. Configure here.

@Quexington
Quexington requested a review from a team as a code owner August 19, 2026 23:07
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 19, 2026
@Quexington
Quexington temporarily deployed to windows-code-signing August 19, 2026 23:07 — with GitHub Actions Inactive
@Quexington
Quexington marked this pull request as draft August 19, 2026 23:12
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 32311884604

Coverage decreased (-0.01%) to 90.187%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • 15 coverage regressions across 8 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

15 previously-covered lines in 8 files lost coverage.

File Lines Losing Coverage Coverage
chia/wallet/did_wallet/did_wallet.py 5 87.69%
chia/_tests/core/util/test_lockfile.py 3 88.5%
chia/timelord/timelord.py 2 71.15%
chia/full_node/full_node.py 1 84.3%
chia/server/server.py 1 80.15%
chia/_tests/simulation/test_simulation.py 1 93.84%
chia/wallet/wallet_node.py 1 84.9%
chia/wallet/wallet_state_manager.py 1 92.09%

Coverage Stats

Coverage Status
Relevant Lines: 126201
Covered Lines: 116370
Line Coverage: 92.21%
Relevant Branches: 24836
Covered Branches: 19846
Branch Coverage: 79.91%
Branches in Coverage %: Yes
Coverage Strength: 1.84 hits per line

💛 - Coveralls

@danieljperry danieljperry changed the title Delete NFT Bulk Minting endpoints [CHIA-4363] Delete NFT Bulk Minting endpoints Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant