[CHIA-4363] Delete NFT Bulk Minting endpoints - #21298
Draft
Quexington wants to merge 1 commit into
Draft
Conversation
Quexington
temporarily deployed
to
windows-code-signing
August 19, 2026 23:07 — with
GitHub Actions
Inactive
Quexington
marked this pull request as draft
August 19, 2026 23:12
Coverage Report for CI Build 32311884604Coverage decreased (-0.01%) to 90.187%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions15 previously-covered lines in 8 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Removes a public wallet RPC capability and large mint code paths; clients relying on
nft_mint_bulkwill break, though core single-mint behavior remains.Overview
Removes NFT bulk minting from the wallet stack: the
nft_mint_bulkRPC handler, client stub, and RPC metadata entry are deleted, along withmint_from_didandmint_from_xchonNFTWallet(intermediate-launcher chunked mint flows).The entire
test_nft_bulk_mint.pysuite (~625 lines) is removed.nft_wallet.pyimport cleanup drops unused DID puzzle / singleton helpers tied to those paths.Single-NFT minting (
generate_new_nft,NFTMintNFTRequest) and other bulk operations (set_bulk_nft_did,bulk_transfer_nft,nft_set_did_bulk,nft_transfer_bulk) are unchanged.Reviewed by Cursor Bugbot for commit a34e7ef. Bugbot is set up for automated code reviews on this repo. Configure here.