Conversation
Pull Request Test Coverage Report for Build 23289762662Details
💛 - Coveralls |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| Ok(Reduction(cost, _result)) => { | ||
| println!("cost: {cost}"); | ||
| println!("execution time: {duration:.3?}"); | ||
| let ns_per_cost = duration.as_nanos() as f64 / cost as f64; |
There was a problem hiding this comment.
Division by zero when cost is zero
Low Severity
The ns_per_cost computation divides by cost as f64, which produces inf or NaN when cost is zero. While Rust's f64 division by zero won't panic, the printed output (ns/cost: inf or ns/cost: NaN) would be confusing. A guard checking for zero cost before computing and printing this metric would make the tool's output cleaner.
|
'This PR has been flagged as stale due to no activity for over 60 |
1 participant
improve output and ability to read parameters from a hex file
Note
Low Risk
Low risk CLI-only change: adds an alternative way to provide the CLVM environment and adjusts printed execution metrics without affecting core library behavior.
Overview
run-clvmnow supports passing the CLVM environment via--envfile(hex-encoded serialized node) as an alternative to--envarguments, with clap-enforced mutual exclusion.Output is tweaked to print execution time in both success and failure cases and, on success, include a derived performance metric (
ns/cost).Written by Cursor Bugbot for commit 1ab7c73. This will update automatically on new commits. Configure here.