ADR-189 alignment: drop redundant SceneryTrait adds in book + Family Zoo#169
Merged
ChicagoDave merged 1 commit intoJun 25, 2026
Merged
Conversation
…rait adds for SCENERY-typed entities Now that createEntity(name, EntityType.SCENERY) auto-adds SceneryTrait (world-model v1.2.0), explicit addTrait(new SceneryTrait()) calls on SCENERY-typed entities are redundant and misleading. Removed from all affected book chapters and all 13 Family Zoo tutorial files. Book: ch05 reworked to teach "EntityType.SCENERY carries the behavior"; prose/comments in ch02/04/12 updated; ch07/08 silent removals. Non-SCENERY fixed things (CONTAINER/SUPPORTER/ DOOR/ITEM) retain their explicit SceneryTrait as required. Tutorial: 158 redundant adds removed across ch02–ch23; package.json @sharpee/* deps corrected to real published versions (world-model/lang-en-us/stdlib ^1.2.0, others at their actual 1.1.x); pnpm-lock.yaml regenerated from standalone install. Validated: familyzoo builds clean on 1.2.0; scenery is fixed, items remain portable. Co-Authored-By: Claude <noreply@anthropic.com>
|
❌ The last analysis has failed. |
ChicagoDave
added a commit
that referenced
this pull request
Jun 25, 2026
…nc emdash-ch05 review doc Rewrites the "What you get for free" paragraph in ch05 away from a colon-swap fix, grounding the prose in the player's default container ability. Updates emdash-ch05.md to record ch05 as integrated for ADR-189 and marks entry #2 as REWRITTEN (post-PR #169 cleanup). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR-189 made
createEntity(name, EntityType.SCENERY)auto-add aSceneryTrait(shipped inworld-model@1.2.0). This PR aligns the book and the Family Zoo tutorial to that behavior: the redundant explicitSceneryTraitadds are removed from SCENERY-typed entities, and the prose updated to teach "theEntityType.SCENERYtype carries the behavior."Book (
docs/book/parts/)SceneryTraitby hand" (only for non-SCENERY fixed things or a custom refusal); both redundant adds dropped; em-dash fixes folded in.SceneryTraitadds removed in ch02, 04, 07, 08, 12 (12 sites); stale prose/comments that described the removed adds fixed in ch02, ch04, ch12.SceneryTrait(dispenser=CONTAINER, parkBench=SUPPORTER, staffGate=DOOR, radio=ITEM, souvenirPress=CONTAINER).Tutorial (
tutorials/familyzoo/)ch*.tsfiles (158 sites); 46 non-SCENERY adds kept.package.json@sharpee/*deps corrected to the real published versions (world-model/lang-en-us/stdlib^1.2.0, the rest at their actual1.1.x);pnpm-lock.yamlupdated.Validation
.sharpeebundle + browser client).world-model@1.2.0auto-addsSceneryTraitto SCENERY, not to ITEM (verified directly).iron fence,rabbits) and items portable (zoo map,bag of animal feed) — exactly what the v01/v03 transcripts assert.Follow-ups (not in this PR)
1.2.0but should have been the next1.1.xpatch (incremental line); a corrected republish + matching familyzoo dep update is pending../repokit build) to clear a stale-bundleworld.helpers()split; standalone behavior is already confirmed.🤖 Generated with Claude Code