Conversation
- implement field-level recovery to preserve valid preferences - backup original incompatible config next to the config file - fall back to defaults only for invalid or unknown fields - rewrite config in current format after recovery - add tests for recovery scenarios including out-of-range, type mismatch, non-UTF-8, and backup collision - prevents loss of user customizations when configuration format changes
ChouChiu
marked this pull request as ready for review
July 18, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture and runtime boundaries
Configuration recovery
.incompatible(with collision-safe numeric suffixes) before rewriting the recovered configuration in the current formatFrontend behavior
boxed-liststyling from manual-search candidates so the split-pane candidate column and rows remain squareCI and release automation
Buildworkflow with a focusedCIworkflow for pull requests,mainpushes, and manual dispatches.deband.rpmfiles into an isolateddistdirectory, and transfer them as one artifactWhy
Several application and domain modules had accumulated unrelated responsibilities. GTK presentation code, asynchronous lyrics work, cache access, persisted configuration, and mutable playback state were coupled closely enough to make changes difficult to test and stale results harder to reject safely.
The workflows also repeated expensive checks and packaging work across branch pushes, pull requests, and releases. This change establishes clearer dependency boundaries, keeps blocking persistence away from the UI thread, preserves usable preferences when configuration formats drift, restores AMLL's intended transition behavior, and gives CI and release workflows distinct responsibilities.
Impact and compatibility
Validation
Latest-head GitHub Actions passed the
Frontend and Rust qualityjob, covering:bun install --frozen-lockfilebun run checkbun run typecheckbun testcargo fmt --all -- --checkcargo clippy --locked --all-targets --all-features -- -D warningscargo test --locked --all-targets --all-featurescargo docscargo build --locked --releaseAdditional validation recorded during the change:
bun run build:lyricsactionlint .github/workflows/*.yml.deband.rpmgeneration with exactly two release assetsgit diff --checkThe final UI was not manually exercised in a real layer-shell Wayland session.