Refactor data sources for leaderboard#1746
Merged
Merged
Conversation
ph-kev
force-pushed
the
kp/data-loader
branch
9 times, most recently
from
5c9079e to
d089a25
Compare
ph-kev
force-pushed
the
kp/data-loader
branch
2 times, most recently
from
2bd1d57 to
f8831c4
Compare
AlexisRenchon
approved these changes
May 20, 2026
AlexisRenchon
left a comment
AlexisRenchon
left a comment
Member
There was a problem hiding this comment.
Looks good to me! I will adapt my future calibration PRs to this design. Thank you Kevin!
nefrathenrici
approved these changes
May 21, 2026
ph-kev
force-pushed
the
kp/data-loader
branch
4 times, most recently
from
4666f04 to
e79e8af
Compare
ph-kev
added a commit
that referenced
this pull request
Jun 1, 2026
This was missed when #1746 was merged in.
ph-kev
added a commit
that referenced
this pull request
Jun 2, 2026
This was missed when #1746 was merged in.
ph-kev
added a commit
that referenced
this pull request
Jun 2, 2026
This was missed when #1746 was merged in.
ph-kev
added a commit
that referenced
this pull request
Jun 2, 2026
This was missed when #1746 was merged in.
imreddyTeja
pushed a commit
that referenced
this pull request
Jun 3, 2026
This was missed when #1746 was merged in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the data sources for the leaderboard to use the struct
DataLoaders. This replaces the dictionary that map names to functions which then takes a start date to materialize theOutputVar. This is currently being used for the coupler calibration (see https://github.com/CliMA/ClimaCoupler.jl/blob/main/src/CalibrationTools.jl).This PR is one step towards attempting to keep the interface for the coupler and land calibration pipelines roughly the same.
The PR reverts the downgrade test to use v1 instead of v2 since it is simpler to understand and debug. There were also problems with the Project.toml.
TODO