Skip to content

Modify broadcast to work with ClimaCore bug#1754

Merged
imreddyTeja merged 1 commit into
ts/bump-patch-releasefrom
tr/temp-fix
May 29, 2026
Merged

Modify broadcast to work with ClimaCore bug#1754
imreddyTeja merged 1 commit into
ts/bump-patch-releasefrom
tr/temp-fix

Conversation

@imreddyTeja

@imreddyTeja imreddyTeja commented May 28, 2026

Copy link
Copy Markdown
Member

Purpose

This is a temporary work-around for the regression caused by the new ClimaCore release.

To-do

  • alternatively, we can cap the ClimaCore version used in the tests. This should not impact the coupler, because I believe the issue is only with the Richards model

  • I have read and checked the items on the review checklist.

@imreddyTeja imreddyTeja marked this pull request as ready for review May 28, 2026 23:37
@juliasloan25

Copy link
Copy Markdown
Member

@kmdeck does this change look ok to you? I think it's fine but I don't remember why we wrote it like that

@imreddyTeja

Copy link
Copy Markdown
Member Author

@kmdeck does this change look ok to you? I think it's fine but I don't remember why we wrote it like that

can dt_gamma be an ITime?

@kmdeck

kmdeck commented May 29, 2026

Copy link
Copy Markdown
Member

@kmdeck does this change look ok to you? I think it's fine but I don't remember why we wrote it like that

I'm not sure which change you are referring to, but I assume the FT(-1)*dtgamma. I think we did it this way because it maps onto the way we write the tendency (-divergence(-Kgrad h), negative divergence of a flux), instead of cancelling out the signs. It might also matter in that we put a boundary condition on the flux, not minus the flux, and if we cancel out the signs, maybe our BC should be on the negative of the flux.

My only other thought is that we add dtgamma*Matrix + I, and I is unitless, so if dtgamma is ITime, does anything funky happen? Probably we should call float(dtgamma) as it is in the PR now

@imreddyTeja imreddyTeja force-pushed the tr/temp-fix branch 3 times, most recently from f4379eb to 5d330a3 Compare May 29, 2026 19:30
@imreddyTeja imreddyTeja merged commit 6deacf1 into ts/bump-patch-release May 29, 2026
15 checks passed
@imreddyTeja imreddyTeja deleted the tr/temp-fix branch May 29, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants