Skip to content

chore(maintenance): 🤖 upgrade vite to v8#929

Open
punkbit wants to merge 11 commits intomainfrom
chore/maintenance-upgrade-vite-to-v8
Open

chore(maintenance): 🤖 upgrade vite to v8#929
punkbit wants to merge 11 commits intomainfrom
chore/maintenance-upgrade-vite-to-v8

Conversation

@punkbit
Copy link
Copy Markdown
Collaborator

@punkbit punkbit commented Mar 13, 2026

Why?

This upgrade vite to the latest v8 by keeping the current project's build tooling or setup. Consequently, storybooks have also upgraded to the 10.3.0 version for compatibility with Vite 8.

⏳ The branch/PR will be kept on the side for further iterations and confirmation's healthy.

How?

  • Upgraded Vite from ^7.3.0 to ^8.0.0
  • Upgraded Storybook packages from 10.1.10 to >= 10.3.0 (required for Vite 8 support)
  • Upgraded @vitejs/plugin-react from ^5.1.2 to ^6.0.0
  • Migrated from MDX to TSX for Introduction stories due to Rolldown's stricter module requirements
  • Removed vite-tsconfig-paths (no longer needed)
  • Added Vite 8 workaround in storybook config to filter vite-plugin-externalize-deps (Rolldown doesn't support function-based externals)
  • Cleaned up old MDX shim workarounds from Storybook config

Preview?

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 13, 2026

⚠️ No Changeset found

Latest commit: ab7af02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@punkbit punkbit force-pushed the chore/maintenance-upgrade-vite-to-v8 branch from 6a51c10 to 3e4cbbc Compare March 24, 2026 10:43
@punkbit punkbit marked this pull request as ready for review March 24, 2026 10:43
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 7, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 7, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 7, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 7, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Claude finished @punkbit's task in 40s —— View job


PR Review: chore(maintenance): 🤖 upgrade vite to v8

  • Read CLAUDE.md and conventions
  • Analyze changed files
  • Provide review feedback

✅ The previously flagged plugin filter has been fixed correctly in .storybook/main.ts:39-46. The new implementation properly handles all valid PluginOption shapes — null/false, nested arrays, Promises, and named plugin objects — and only removes vite-plugin-externalize-deps as intended.

Everything else looks solid:

  • rollupOptionsrolldownOptions in vite.config.ts
  • resolve.tsconfigPaths: true (replaces vite-tsconfig-paths) ✅
  • Storybook pinned to stable ^10.3.3 (no more alpha) ✅
  • MDX → TSX migration for Introduction stories ✅
  • @vitejs/plugin-react upgraded to ^6.0.0

No issues found. 🙌

@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 7, 2026
@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-9ois8irhk-clickhouse.vercel.app

Built from commit: 9bfab5e62e71718e16934f0804129cebe2c2b320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants