chore(css-modules): 🤖 support local visual regression testing via docker#931
Conversation
|
|
Claude finished @punkbit's task in 1m 45s —— View job PR Review
Solid PR — the Dockerized visual regression approach is the right call for cross-OS consistency, and the test coverage is thorough. All previous feedback has been addressed. Here's the full picture: ✅ Previously addressed
💡 Suggestions (non-blocking)
✅ Everything looks good — clean implementation, well-structured tests covering all button variants, interactive states, and a11y checks (disabled + loading aria attributes, keyboard navigation). Nice work! 🙌 |
|
Claude finished @punkbit's task in 1m 52s —— View job PR Review
Solid Docker + visual regression setup. The approach is well-structured and the test coverage is comprehensive. One carry-over from the previous review plus a new observation: 💡 Suggestions (non-blocking)
✅ Everything looks good — Docker setup is clean, tests cover all button variants (types, loading, disabled, icons, layout, interactive states, a11y), and snapshots are correctly scoped to linux/chromium. Nice work! 🙌 |
…reenshot comparisons
…ar. The docker rm -f playwright-ui command handles both stopping and removing the container
…rrect for a group of related buttons) and updated the test to use page.getByRole('group')
f98c9bc to
04234a0
Compare
|
Claude finished @punkbit's task in 1m 24s —— View job PR Review
Solid, well-structured PR. Docker setup is clean, test coverage is thorough across button variants, themes, states, and a11y. Two carry-over suggestions remain unresolved, plus one new observation: 💡 Suggestions (non-blocking)
✅ No blocking issues — clean implementation, snapshots are correctly scoped to |
📚 Storybook Preview Deployed✅ Preview URL: https://click-l5ye1115c-clickhouse.vercel.app Built from commit: |
Why?
Ensures consistent visual regression snapshots by enabling local testing within a Dockerized environment. This prevents false positive diffs caused by operating system variations, e.g., macOS vs. linux.
How?
Preview?