Skip to content

chore(monorepo): 🤖 file re-architecture, mono-repository migration#938

Open
punkbit wants to merge 13 commits intomainfrom
chore/monorepo-migration
Open

chore(monorepo): 🤖 file re-architecture, mono-repository migration#938
punkbit wants to merge 13 commits intomainfrom
chore/monorepo-migration

Conversation

@punkbit
Copy link
Copy Markdown
Collaborator

@punkbit punkbit commented Mar 23, 2026

Why?

The Click UI project is a single package that is growing to meet the needs of different consumer apps. As it grows, different concerns and priorities come into play.

For example, if it contained assets as a dependency, which are consumed through a stable API, it'd mean that when a new version of assets is released (e.g. 1.0.0 → 1.1.0), Click UI would automatically pick up the update without requiring consumer apps to take any action, as long as the new version falls within the compatible version range.

Furthermore, other concerns can be separated, such as design tokens, etc.

How?

  • Leverage yarn workspace for monorepo
  • Update GitHub Action/Workflows
  • Update supporting scripts

Preview?

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 23, 2026

⚠️ No Changeset found

Latest commit: c441cdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@punkbit punkbit force-pushed the chore/monorepo-migration branch from 6f98dee to f2d1e91 Compare March 31, 2026 10:52
@punkbit punkbit changed the title chore(file-architecture): 🤖 mono-repository migration chore(monorepo): 🤖 file re-architecture, mono-repository migration Mar 31, 2026
@punkbit punkbit force-pushed the chore/monorepo-migration branch from f2d1e91 to ac812a6 Compare April 2, 2026 10:20
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 2, 2026
@punkbit
Copy link
Copy Markdown
Collaborator Author

punkbit commented Apr 2, 2026

  • release-publisher.yml:120 and create-release.yml:109: Both still use yarn install --frozen-lockfile. This is a Yarn 1 flag — with packageManager: yarn@4.5.3, it is silently ignored and lockfile integrity is not enforced. All other workflows in this repo already use --immutable correctly (chromatic, code-quality, build-health-checkup, storybook-vercel, unit-tests, publish). These two need to match.

    Note: I'm unable to modify .github/workflows/ files directly due to GitHub App permissions.

There's a pending pull request addressing this at #967. Do ignore, please!

@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 2, 2026
@punkbit punkbit force-pushed the chore/monorepo-migration branch from e666464 to c441cdc Compare April 2, 2026 11:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Claude finished @punkbit's task in 1m 54s —— View job


PR Review: chore(monorepo): 🤖 file re-architecture, mono-repository migration

  • Read CLAUDE.md and conventions
  • Review current state of PR changes
  • Post final review

The monorepo migration is in great shape. Here's the current state after the latest commits:

What's confirmed good:

  • Root package.json is correctly minimal — private workspace root, packageManager: yarn@4.5.3, topological orchestration via workspaces foreach -A --topological
  • packages/click-ui/package.jsonpackageManager and engines removed ✅ (commit e0815517)
  • .husky/pre-commit — delegates all checks correctly; circular-dependency check is now unconditional, changeset:verify and circular-dependency:check properly scoped to yarn workspace @clickhouse/click-ui
  • release-publisher.yml:120 and create-release.yml:109 — both now use --immutable ✅ (the --frozen-lockfile issue from prior reviews is resolved)
  • Workflow working-directory: packages/click-ui applied consistently across build, package-info, publish, and npm-publish steps
  • Public @clickhouse/click-ui API and exports are untouched — no breaking changes

💡 Suggestions (non-blocking)

  • release-publisher.yml:105 / create-release.yml:93: Both use node-version: '23.x', while publish.yml:83 uses 22.x (with a comment that Node 22 is the minimum for npm OIDC support). Root engines also pins >=22.12.0. Worth aligning to 22.x for consistency.

Everything looks great — ready to merge! 🙌

@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-apevfvici-clickhouse.vercel.app

Built from commit: 962d6a913b7aebe79d3eb63d663c20af0f483ff6

@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 2, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 2, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 2, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants