Skip to content

chore(monorepo): 🤖 setup changeset handling from root#951

Open
punkbit wants to merge 11 commits intochore/monorepo-migrationfrom
chore/monorepo-changeset-root-setup
Open

chore(monorepo): 🤖 setup changeset handling from root#951
punkbit wants to merge 11 commits intochore/monorepo-migrationfrom
chore/monorepo-changeset-root-setup

Conversation

@punkbit
Copy link
Copy Markdown
Contributor

@punkbit punkbit commented Mar 25, 2026

Why?

In a monorepository, a changeset setup expects handling to happen from its root.

How?

  • Move changeset commands to root package.json
  • Move changeset specific script handlers to root
  • Move pending changesets to root
  • Provide documentation

Preview?

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2026

⚠️ No Changeset found

Latest commit: 95858ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 25, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 25, 2026
@punkbit punkbit marked this pull request as ready for review March 25, 2026 18:22
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 25, 2026
@punkbit punkbit force-pushed the chore/monorepo-migration branch from 6f98dee to f2d1e91 Compare March 31, 2026 10:52
@punkbit punkbit force-pushed the chore/monorepo-changeset-root-setup branch from 04de869 to 8899067 Compare March 31, 2026 12:11
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 31, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 31, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 31, 2026
@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Claude finished @punkbit's task in 1m 30s —— View job


PR Review: chore(monorepo): 🤖 setup changeset handling from root

  • Read CLAUDE.md conventions
  • Read changed files (create-release.yml, scripts, package.json, README.md)
  • Analyze and write review

Good infrastructure work — the migration is clean and consistent. The previous review flagged a stale script path in create-release.yml:252, and that has since been fixed in commit 507b3f3 (fix: 🐛 changed the script path). All paths now resolve correctly.

What was verified:

  • create-release.yml:252 — correctly calls .scripts/bash/generate-release-commit-message (root path, not the old packages/click-ui/.scripts/...)
  • create-release.yml:204-205require('./packages/click-ui/package.json') is intentionally correct; this is where the publishable package lives
  • Root package.jsonchangeset:add, changeset:status, changeset:verify, changeset:version all present and wired to the right scripts
  • .changeset/config.jsonbaseBranch: "main" is correct for the monorepo
  • .scripts/bash/changeset-add and .scripts/bash/changeset-verification — both use relative .changeset/ paths, which resolve correctly when called from root
  • packages/click-ui/package.json — changeset scripts and @changesets/cli dependency correctly removed
  • README.md:40 — link to ./packages/click-ui/docs/package-release.md is valid and the doc content correctly references root-level yarn changeset:add commands

✅ Looks good — no remaining issues found. Nice work! 🙌

@ClickHouse ClickHouse deleted a comment from github-actions bot Mar 31, 2026
@punkbit punkbit force-pushed the chore/monorepo-migration branch 2 times, most recently from e666464 to c441cdc Compare April 2, 2026 11:52
@punkbit punkbit force-pushed the chore/monorepo-changeset-root-setup branch from 507b3f3 to a69cc75 Compare April 2, 2026 15:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Claude finished @punkbit's task in 32s —— View job


PR Review: chore(monorepo): 🤖 setup changeset handling from root

  • Read CLAUDE.md conventions
  • Read changed files
  • Analyze and write review

Clean migration — the changeset tooling is now correctly wired at the monorepo root. All paths and script references have been updated consistently.

Looks great! No issues found — nice work!

Quick notes on what was verified:

  • create-release.yml — all yarn workspace @clickhouse/click-ui changeset ... calls correctly replaced with root-level yarn changeset ...
  • .changeset/pre.json — correctly migrated from packages/click-ui/.changeset/pre.json; pre-release state preserved
  • .changeset/config.jsonbaseBranch: "main" is correct; access: "public" appropriate for a published library
  • package.json@changesets/cli added to root devDependencies; all four changeset:* scripts present and wired correctly
  • .scripts/bash/changeset-add and .scripts/bash/changeset-verification — both use relative .changeset/ paths, resolving correctly from root
  • packages/click-ui/package.json — changeset scripts and @changesets/cli dep cleanly removed
  • README.md — docs are clear and accurate; link to ./packages/click-ui/docs/package-release.md is valid

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Claude finished @punkbit's task in 49s —— View job


PR Review: chore(monorepo): 🤖 setup changeset handling from root

  • Read CLAUDE.md conventions
  • Read changed files
  • Analyze and write review

This is a clean infrastructure migration — no component changes. Reviewed against the diff from origin/chore/monorepo-migration.

Looks great! No issues found — nice work!

What was verified:

  • create-release.yml — all yarn workspace @clickhouse/click-ui changeset ... calls correctly replaced with root-level yarn changeset ...; .changeset/pre.json path references updated consistently
  • package.json (root) — @changesets/cli added to devDependencies; all four changeset:* scripts present and wired correctly
  • packages/click-ui/package.json — changeset scripts and @changesets/cli dep cleanly removed; no regressions
  • .changeset/config.jsonbaseBranch: "main", access: "public" — correct
  • .scripts/bash/changeset-add — uses relative .changeset/ path, resolves correctly from root
  • packages/click-ui/.changeset/pre.json — correctly removed (confirmed by fix: 🐛 remove pre-release pre.json commit)
  • README.md (root) — clear contributor docs covering changeset:add, changeset:status, changeset:version

@workflow-authentication-public
Copy link
Copy Markdown
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-vt9pogqwr-clickhouse.vercel.app

Built from commit: bc82f5c31f49259c8e394ec74ed8037e10e95152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants