add getMap and isMap in Config#1902
Open
SenseiTarzan wants to merge 2 commits intoCloudburstMC:masterfrom
Open
add getMap and isMap in Config#1902SenseiTarzan wants to merge 2 commits intoCloudburstMC:masterfrom
SenseiTarzan wants to merge 2 commits intoCloudburstMC:masterfrom
Conversation
Contributor
|
What's the point? ConfigSection implements Map already |
Author
I do not understand your but if it is that has what the function getMap it is just because there is the getListMap but notgetMap which allows him to do many things |
|
ConfigSection already extends Map, so your PR is useless - getSection() does basically the same thing as your suggested code. |
Author
|
getSection works every other time after creating a config it doesn't work anymore after restarting you can see on this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as I saw that getMap and isMap don't exist I add them