Make Nukkit more kotlin friendly: Commands#2041
Open
xISRAPILx wants to merge 1 commit intoCloudburstMC:masterfrom
Open
Make Nukkit more kotlin friendly: Commands#2041xISRAPILx wants to merge 1 commit intoCloudburstMC:masterfrom
xISRAPILx wants to merge 1 commit intoCloudburstMC:masterfrom
Conversation
Creeperface01
approved these changes
Aug 20, 2022
Contributor
|
Is this WIP or can it be merged? |
xISRAPILx
force-pushed
the
kotlin_friendly
branch
from
52ecf3a to
a521d75
Compare
Contributor
Author
You can. I will open new merge requests if I find other critical things in the API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why not lombok.NonNull?
I hate lombok and believe it can be removed from project))
Before:
After: