Remove Timings and bundle Spark#2117
Open
Villagers654 wants to merge 5 commits intoCloudburstMC:masterfrom
Open
Remove Timings and bundle Spark#2117Villagers654 wants to merge 5 commits intoCloudburstMC:masterfrom
Villagers654 wants to merge 5 commits intoCloudburstMC:masterfrom
Conversation
Member
|
Is it intentionally only downloading Spark when the server is reloaded? Also, there should probably be a setting to disable Spark download. |
Author
|
To make a config change, do I have to write a PR to Languages? Or am I missing something |
Member
Yes. The default nukkit.yml is loaded from language submodule and it isn't updated automatically because that would remove all comments I think. |
Member
|
Noticed a few |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since timings is being deprecated and removed by Paper #8948 and its forks, it makes sense for Nukkit to follow suit and remove timings in favor of Spark.
This PR removes Timings from the server completely, and then installs Spark automatically (unless the user already has installed Spark as a plugin)
The method of installing Spark is based on Purpur #1020