Implement sup element for Slipstream#235
Merged
jverkoey merged 2 commits intoNov 6, 2025
Merged
Conversation
Added the Sup element following the established pattern for inline text elements. The implementation includes: - Sup.swift: The superscript element view that conforms to W3CElement - SupTests.swift: Tests for empty and text-based sup elements - Updated SlipstreamForWebDevelopers.md to document the new element The Sup element supports both ViewBuilder content and a convenience initializer for string literals, consistent with other text-level semantic elements.
Renamed the Sup element to Superscript to follow SwiftUI naming conventions of using longer, more descriptive names. Also implemented the Subscript element for the <sub> HTML tag. Changes: - Renamed Sup.swift to Superscript.swift with updated naming throughout - Added Subscript.swift for subscript text (H₂O example in docs) - Updated SuperscriptTests.swift (renamed from SupTests.swift) - Added SubscriptTests.swift with tests for empty and text content - Updated SlipstreamForWebDevelopers.md to document both elements Both elements follow the established pattern for inline text elements, supporting ViewBuilder content and string literal convenience initializers.
jverkoey
deleted the
claude/implement-sup-element-011CUqB753nzYrQLMwxJXZx1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Sup element following the established pattern for inline text elements. The implementation includes:
The Sup element supports both ViewBuilder content and a convenience initializer for string literals, consistent with other text-level semantic elements.
Part of #25