Build HTML content with Swift DSL#238
Closed
jverkoey wants to merge 1 commit into
Closed
Conversation
This change allows users to use plain string literals in view builders
instead of explicitly wrapping text in DOMString().
Before:
```swift
Paragraph {
DOMString("I ")
Emphasis("really")
DOMString(" want to go to the concert.")
}
```
After:
```swift
Paragraph {
"I "
Emphasis("really")
" want to go to the concert."
}
```
Implementation details:
- Made DOMString conform to ExpressibleByStringLiteral
- Added buildExpression method to ViewBuilder to convert string literals to DOMString
- Added comprehensive tests for string literal support
This makes the API more ergonomic and consistent with SwiftUI patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to use plain string literals in view builders instead of explicitly wrapping text in DOMString().
Before:
After:
Implementation details:
This makes the API more ergonomic and consistent with SwiftUI patterns.