Implement HTML ruby and quote elements#242
Merged
jverkoey merged 1 commit intoNov 6, 2025
Merged
Conversation
This commit implements four new HTML text-level semantic elements for Slipstream: - Quote (q): Represents short inline quotations with optional cite attribute - Ruby (ruby): Container for ruby annotations used in East Asian typography - RubyText (rt): Ruby text component for annotations - RubyParenthesis (rp): Fallback parentheses for browsers without ruby support The Quote element follows the View-based pattern as it includes an optional cite attribute for specifying the source URL of the quotation. The Ruby, RubyText, and RubyParenthesis elements use the simpler W3CElement pattern as they don't require attributes. All elements include: - Comprehensive documentation with usage examples - Support for both ViewBuilder content and text initializers - Full test coverage - Updated documentation mapping in SlipstreamForWebDevelopers.md These implementations follow SwiftUI idioms while honoring W3C terminology, maintaining consistency with existing Slipstream elements like Bold, Italic, and Emphasis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements four new HTML text-level semantic elements for Slipstream:
The Quote element follows the View-based pattern as it includes an optional cite attribute for specifying the source URL of the quotation. The Ruby, RubyText, and RubyParenthesis elements use the simpler W3CElement pattern as they don't require attributes.
All elements include:
These implementations follow SwiftUI idioms while honoring W3C terminology, maintaining consistency with existing Slipstream elements like Bold, Italic, and Emphasis.
Part of #25