Skip to content

Add Danbooru Tag JP Assist#3046

Open
ukr8b3g-cmyk wants to merge 1 commit into
Comfy-Org:mainfrom
ukr8b3g-cmyk:add-danbooru-tag-jp-assist
Open

Add Danbooru Tag JP Assist#3046
ukr8b3g-cmyk wants to merge 1 commit into
Comfy-Org:mainfrom
ukr8b3g-cmyk:add-danbooru-tag-jp-assist

Conversation

@ukr8b3g-cmyk

Copy link
Copy Markdown

Adds Danbooru Tag JP Assist to the new custom node list.

Repository: https://github.com/ukr8b3g-cmyk/Danbooru-Tag-JP-Assist

Features:

  • Japanese-assisted tag autocomplete for ComfyUI text areas
  • Danbooru tag CSV support with optional Hugging Face update
  • Bundled natural language tags and Japanese translation files
  • Local CSV tag and translation file selection

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7b7e65da-8f40-42ba-bedf-526419cb4527

📥 Commits

Reviewing files that changed from the base of the PR and between 2885580 and 2c4bdb0.

📒 Files selected for processing (1)
  • node_db/new/custom-node-list.json

📝 Walkthrough

Walkthrough

A new entry for the "Danbooru Tag JP Assist" custom node was added to node_db/new/custom-node-list.json, including author, title, GitHub reference/files URL, install_type as git-clone, and a description of its Japanese tag autocomplete and Danbooru CSV update feature.

Changes

Node List Entry Addition

Layer / File(s) Summary
Add new custom node metadata
node_db/new/custom-node-list.json
A new object for "Danbooru Tag JP Assist" is added to the custom_nodes array with author, title, reference, files, install_type, and description fields.

Possibly related PRs

  • Comfy-Org/ComfyUI-Manager#2990: Both PRs append a new custom-node metadata entry to the same node_db/new/custom-node-list.json file with matching field structure.

Poem
A tiny JSON hop, a node in tow,
"Danbooru Tag JP" joins the show.
No bugs to squash, no code to fix,
Just one more entry in the mix — 🐰✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.

@ltdrdata

ltdrdata commented Jul 4, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution! Before this can be merged, the ComfyUI settings UI strings need to be in English:

  • web/danbooru_tag_jp_assist.js — the settings name labels, category breadcrumbs, and combo option text values include Japanese text alongside English (e.g. Enable suggestions / 補完を有効化, Tag source / タグ元, Both / 両方). Please make the Japanese half opt-in via a locale rather than always appended, or remove it and ship English-only in the repo.

For multilingual support, refer to the locale feature:
Comfy-Org/ComfyUI#6558

I'll re-evaluate once the UI strings are English-only or the Japanese labels are routed through the locale system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants