Add ResolutionMaster preemption for Comfyui-Resolution-Master#3057
Merged
ltdrdata merged 1 commit intoJul 6, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a ChangesNode list metadata update
Compact metadata
No bugs here to squash or seize, just one small array that's sure to please—ResolutionMaster now preempts with ease! 🐰✨ 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ResolutionMaster as a preemption for Azornes/Comfyui-Resolution-Master in custom-node-list.json.
Context
Comfyui-Resolution-Master is the original provider of the ResolutionMaster ComfyUI node used by existing workflows.
Another node pack now also registers a node with the same technical node id/class type: ResolutionMaster. This creates an ambiguous mapping in ComfyUI-Manager. When users load workflows with missing nodes and use the missing-node installer, Manager can suggest or install the conflicting package, which may cause workflows expecting Comfyui-Resolution-Master to load the wrong implementation.
Change
This PR marks Azornes/Comfyui-Resolution-Master as the preferred provider for the ResolutionMaster node id:
json "preemptions": [ "ResolutionMaster" ]This does not remove or block the other node pack. It only helps ComfyUI-Manager resolve the ResolutionMaster node id to the original package when installing missing nodes.
Related repositories
Original node:
https://github.com/Azornes/Comfyui-Resolution-Master
Conflicting node pack:
https://github.com/axces2000/comfyui-axces2000