Skip to content

Add ResolutionMaster preemption for Comfyui-Resolution-Master#3057

Merged
ltdrdata merged 1 commit into
Comfy-Org:mainfrom
Azornes:azornes-resolutionmaster-preemption
Jul 6, 2026
Merged

Add ResolutionMaster preemption for Comfyui-Resolution-Master#3057
ltdrdata merged 1 commit into
Comfy-Org:mainfrom
Azornes:azornes-resolutionmaster-preemption

Conversation

@Azornes

@Azornes Azornes commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds ResolutionMaster as a preemption for Azornes/Comfyui-Resolution-Master in custom-node-list.json.

Context

Comfyui-Resolution-Master is the original provider of the ResolutionMaster ComfyUI node used by existing workflows.

Another node pack now also registers a node with the same technical node id/class type: ResolutionMaster. This creates an ambiguous mapping in ComfyUI-Manager. When users load workflows with missing nodes and use the missing-node installer, Manager can suggest or install the conflicting package, which may cause workflows expecting Comfyui-Resolution-Master to load the wrong implementation.

Change

This PR marks Azornes/Comfyui-Resolution-Master as the preferred provider for the ResolutionMaster node id:

json "preemptions": [ "ResolutionMaster" ]

This does not remove or block the other node pack. It only helps ComfyUI-Manager resolve the ResolutionMaster node id to the original package when installing missing nodes.

Related repositories

Original node:
https://github.com/Azornes/Comfyui-Resolution-Master

Conflicting node pack:
https://github.com/axces2000/comfyui-axces2000

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a44ecc07-ce2b-44c2-bc49-72ab400dc962

📥 Commits

Reviewing files that changed from the base of the PR and between 037987b and 4589109.

📒 Files selected for processing (1)
  • custom-node-list.json

📝 Walkthrough

Walkthrough

Added a preemptions field with value ["ResolutionMaster"] to an existing entry in custom-node-list.json, marking preemption behavior for that node.

Changes

Node list metadata update

Layer / File(s) Summary
Add preemptions field
custom-node-list.json
Inserted a new preemptions array containing "ResolutionMaster" into an existing JSON entry.

Compact metadata

  • Type: Data/config change
  • Files changed: 1
  • Lines changed: +3/-0
  • Review effort: Low

No bugs here to squash or seize, just one small array that's sure to please—ResolutionMaster now preempts with ease! 🐰✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ltdrdata
ltdrdata merged commit cf883eb into Comfy-Org:main Jul 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants