T3022 partner segmentation refactor by Danielgergely · Pull Request #2081 · CompassionCH/compassion-modules

Danielgergely · 2026-02-26T09:06:13Z

REFACTOR: segmentation data now uses the new model-links
CHORE: added partner_segment_link to imports
REFACTOR: removed personalized links and added link_ids
FEAT: created ResPartnerSegmentLink model
REFACTOR: added access rules to new model
REFACTOR: updated partner_segmentation_view to display new links

…d personalized_links - REFACTOR: segmentation data now uses the new model-links - CHORE: added partner_segment_link to imports - REFACTOR: removed personalized links and added link_ids - FEAT: created ResPartnerSegmentLink model - REFACTOR: added access rules to new model - REFACTOR: updated partner_segmentation_view to display new links

gemini-code-assist · 2026-02-26T09:06:36Z

Summary of Changes

Hello @Danielgergely, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the management of personalized links within the partner segmentation module. By introducing a dedicated data model for links, it moves away from storing raw HTML, enhancing data integrity, reusability, and maintainability. This change provides a more structured and manageable way to associate useful resources with specific partner segments, allowing for easier localization and administration of these links.

Highlights

Data Model Refactor: The personalized_links HTML field in res.partner.segment has been replaced with a structured link_ids One2many field, linking to a new dedicated model.
New Model Introduced: A new model, ResPartnerSegmentLink, was created to store individual link details including URL, label, and associated language and category.
Data Migration: Existing personalized links in partner_segmentation_data.xml were migrated from raw HTML to the new structured link_ids format.
Access Control: Access rules were added for the new ResPartnerSegmentLink model to ensure proper permissions.
UI Update: The partner segmentation view was updated to display the new link_ids field using an editable tree widget.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

partner_segmentation/data/partner_segmentation_data.xml
- Replaced the personalized_links field with link_ids and updated the data to use the new structured link format for various partner segments.
partner_segmentation/models/init.py
- Added partner_segment_link to the list of imported modules.
partner_segmentation/models/partner_segment.py
- Removed the personalized_links HTML field.
- Added a link_ids One2many field to res.partner.segment.link to manage structured personalized links.
partner_segmentation/models/partner_segment_link.py
- Created a new model ResPartnerSegmentLink to define structured links with fields for URL, label, language, and category.
partner_segmentation/security/ir.model.access.csv
- Added access rules for the new res.partner.segment.link model, granting full access to base.group_user.
partner_segmentation/views/partner_segmentation_view.xml
- Replaced the personalized_links field in the form view with the new link_ids field, displayed as an editable tree with columns for label, URL, and language.

Activity

The author refactored segmentation data to utilize the newly introduced model-links.
The partner_segment_link module was added to the imports.
The personalized_links field was removed and replaced with link_ids across relevant files.
A new model, ResPartnerSegmentLink, was created to handle structured link data.
Access rules were implemented for the new ResPartnerSegmentLink model.
The partner_segmentation_view was updated to correctly display the new link structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request successfully refactors the personalized links from an HTML field to a structured One2many field, link_ids, which is a significant improvement for data management and flexibility. The new ResPartnerSegmentLink model and its integration into the views and data files are well-implemented. However, there are a few issues related to data migration/consistency and access rights that need attention.

- FIX: added missing links - STYLE: pre-commit - FIX: corrected segmentation link access

Danielgergely · 2026-02-26T09:44:54Z

Related PR for the website: CompassionCH/compassion-website#293

- REFACTOR: Created separate links and referenced them in the data objects

ecino

I would be in favor of using translated fields instead of a language field and record duplications.

Also I would take advantage of the new model to allow a little more flexibility (ability to extend to more resources than just URLs)

ecino · 2026-04-16T08:01:04Z

+<odoo>
+    <record


This is a clear candidate for noupdate as we don't wan't to maintain the module data while the users could edit the links or the resources from the user interface.

Suggested change

<odoo>

<record

<odoo>

<data noupdate="1">

<record

ecino · 2026-04-16T08:03:19Z

+    url = fields.Char(
+        required=True, help="URL of the link to be provided to the partner"
+    )
+    label = fields.Char(
+        required=True, help="Label of the link to be provided to the partner"
+    )
+    language_id = fields.Many2one(
+        "res.lang",
+        string="Language",
+        help="Language of the link, used to provide the link to "
+        "the partner based on their language",
+    )


Why not using translated fields instead of adding records for every language? Translations should be added in .po files This can greatly simplify the architecture in my opinion:

Suggested change

url = fields.Char(

required=True, help="URL of the link to be provided to the partner"

)

label = fields.Char(

required=True, help="Label of the link to be provided to the partner"

)

language_id = fields.Many2one(

"res.lang",

string="Language",

help="Language of the link, used to provide the link to "

"the partner based on their language",

)

resource_type = fields.Selection(

[("url", "URL")],

default="url",

required=True,

)

resource_url = fields.Char(

required=True,

translate=True,

help="URL of the link to be provided to the partner",

)

label = fields.Char(

required=True,

translate=True,

help="Label of the link to be provided to the partner"

)

ecino · 2026-04-16T08:05:04Z

+from odoo import fields, models
+
+
+class ResPartnerSegmentLink(models.Model):


I would go beyond just "links" and think broader with this object as a useful "segment resource" available for this segment of donors. Could you please update the model accordingly?

For now we would only have links but why not including files later (documents), images or videos, etc?

Suggested change

class ResPartnerSegmentLink(models.Model):

class ResPartnerSegmentResource(models.Model):

ecino · 2026-04-16T08:05:21Z

+    category and language.
+    """
+
+    _name = "res.partner.segment.link"


Suggested change

_name = "res.partner.segment.link"

_name = "res.partner.segment.resource"

ecino · 2026-04-16T08:05:33Z

+    """
+
+    _name = "res.partner.segment.link"
+    _description = "Partner Segmentation Link"


Suggested change

_description = "Partner Segmentation Link"

_description = "Partner Segmentation Resource"

Danielgergely · 2026-04-16T09:31:28Z

Put on hold until the partner segmentation is redesigned

Danielgergely added 2 commits February 25, 2026 16:07

[T3022] STYLE: pre-commit

7c7c489

gemini-code-assist Bot reviewed Feb 26, 2026

View reviewed changes

[T3022] FIX: GCA suggestions

4d3e696

- FIX: added missing links - STYLE: pre-commit - FIX: corrected segmentation link access

Danielgergely added 3 commits February 26, 2026 15:20

[T3022] FIX: corrected link languages and labels

b4f4afd

[T3022] FIX: Added separate partner_segmentation_links

0b074f9

- REFACTOR: Created separate links and referenced them in the data objects

[T3022] STYLE: pre-commit

9079a70

Danielgergely mentioned this pull request Mar 2, 2026

T3022 survey CompassionCH/compassion-website#293

Draft

ecino requested changes Apr 16, 2026

View reviewed changes

Danielgergely marked this pull request as draft April 16, 2026 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T3022 partner segmentation refactor#2081

T3022 partner segmentation refactor#2081
Danielgergely wants to merge 6 commits into14.0from
T3022-partner-segmentation-refactor

Danielgergely commented Feb 26, 2026

Uh oh!

gemini-code-assist Bot commented Feb 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Danielgergely commented Feb 26, 2026

Uh oh!

ecino left a comment

Uh oh!

ecino Apr 16, 2026

Uh oh!

ecino Apr 16, 2026

Uh oh!

ecino Apr 16, 2026

Uh oh!

ecino Apr 16, 2026

Uh oh!

ecino Apr 16, 2026

Uh oh!

Danielgergely commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-<odoo>
-    <record
+<odoo>
+    <data noupdate="1">
+        <record

		from odoo import fields, models


		class ResPartnerSegmentLink(models.Model):

	class ResPartnerSegmentLink(models.Model):
	class ResPartnerSegmentResource(models.Model):

	_name = "res.partner.segment.link"
	_name = "res.partner.segment.resource"

	_description = "Partner Segmentation Link"
	_description = "Partner Segmentation Resource"

Conversation

Danielgergely commented Feb 26, 2026

Uh oh!

gemini-code-assist Bot commented Feb 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Danielgergely commented Feb 26, 2026

Uh oh!

ecino left a comment

Choose a reason for hiding this comment

Uh oh!

ecino Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ecino Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ecino Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ecino Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ecino Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Danielgergely commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants