fix(py): support list-valued schema types in tool signatures#3815
Merged
Conversation
Normalize list-valued JSON Schema types in both direct and combiner paths, preventing unhashable-list failures while preserving the existing fallback behavior. Co-authored-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7d4d50f. Configure here.
Use scalar fallback defaults for single-item JSON Schema type lists while preserving explicit defaults and multi-type union behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR:
typefields before scalar type lookupsanyOf/oneOfoptionsContext
JSON Schema Draft 2020-12 and OpenAPI 3.1 allow
typeto be an array. The previous parser passed that list to a dictionary lookup, raisingTypeError: unhashable type: 'list'. This replacement covers the direct case from #3754 and the same shape nested in a combiner.