Skip to content

pre-hashed message in ECDSA and EdDSA#312

Merged
yelhousni merged 4 commits intodevelopfrom
signature/pre-hashed
Jan 31, 2023
Merged

pre-hashed message in ECDSA and EdDSA#312
yelhousni merged 4 commits intodevelopfrom
signature/pre-hashed

Conversation

@yelhousni
Copy link
Copy Markdown
Collaborator

Following the signature interface, for both ECDSA and EdDSA:

// If hFunc is not provided, implementation may consider the message
// to be pre-hashed, else, will use hFunc to hash the message.

Comment thread internal/generator/ecdsa/template/ecdsa.go.tmpl Outdated
Comment thread internal/generator/ecdsa/template/ecdsa.go.tmpl Outdated
@yelhousni yelhousni requested a review from ivokub January 27, 2023 08:15
Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I think is good to merge as-is. Your call if you want to merge currently as-is and have later optional PR if have figured out #322 or wait and incorporate changes.

@yelhousni
Copy link
Copy Markdown
Collaborator Author

Looks good and I think is good to merge as-is. Your call if you want to merge currently as-is and have later optional PR if have figured out #322 or wait and incorporate changes.

I think we can merge now as-is since the two other PRs #313 and #314 are based on this branch. Then we can have a PR that refactor all of the 4 schemes (EdDSA, ECDSA, Schnorr, BLS) in a similar manner as per #322.

@ivokub
Copy link
Copy Markdown
Collaborator

ivokub commented Jan 31, 2023

Looks good and I think is good to merge as-is. Your call if you want to merge currently as-is and have later optional PR if have figured out #322 or wait and incorporate changes.

I think we can merge now as-is since the two other PRs #313 and #314 are based on this branch. Then we can have a PR that refactor all of the 4 schemes (EdDSA, ECDSA, Schnorr, BLS) in a similar manner as per #322.

Makes sense and I agree.

@yelhousni yelhousni merged commit 97cb629 into develop Jan 31, 2023
@yelhousni yelhousni deleted the signature/pre-hashed branch January 31, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants