You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I think is good to merge as-is. Your call if you want to merge currently as-is and have later optional PR if have figured out #322 or wait and incorporate changes.
Looks good and I think is good to merge as-is. Your call if you want to merge currently as-is and have later optional PR if have figured out #322 or wait and incorporate changes.
I think we can merge now as-is since the two other PRs #313 and #314 are based on this branch. Then we can have a PR that refactor all of the 4 schemes (EdDSA, ECDSA, Schnorr, BLS) in a similar manner as per #322.
Looks good and I think is good to merge as-is. Your call if you want to merge currently as-is and have later optional PR if have figured out #322 or wait and incorporate changes.
I think we can merge now as-is since the two other PRs #313 and #314 are based on this branch. Then we can have a PR that refactor all of the 4 schemes (EdDSA, ECDSA, Schnorr, BLS) in a similar manner as per #322.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the signature interface, for both ECDSA and EdDSA: