fix(chat): clamp negative token counts in request log row - #101
Open
ngo-software wants to merge 1 commit into
Open
ngo-software wants to merge 1 commit into
ngo-software wants to merge 1 commit into
Conversation
Some upstream providers return negative token counts in malformed usage data. The cost calculation already clamps via _compute_cost_microcents, but the raw input_tokens/output_tokens columns in RequestLog were unprotected — negative values persisted to the DB corrupt analytics dashboards (negative total tokens, negative spend aggregates). Clamp both fields to max(0, value) at extraction time so the log row never carries negative counts regardless of upstream data quality.
![orcacode-review[bot]](https://avatars.githubusercontent.com/in/4254738?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 346 calls · 19.2M tokens · 98% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
Some upstream providers return negative token counts in malformed usage data. The cost calculation already clamps via
_compute_cost_microcents, but the rawinput_tokens/output_tokenscolumns inRequestLogwere unprotected.Negative values persisted to the DB corrupt analytics dashboards — negative total tokens, negative spend aggregates, broken percentile calculations.
Fix: clamp both fields to
max(0, value)at extraction time in_build_log_row, so the log row never carries negative counts regardless of upstream data quality.Tests:
tests/unit/test_negative_token_clamping.py— verifies negative input tokens, negative output tokens, and both-negative cases all clamp to 0.