Conversation
Some LiteLLM stream wrappers yield None as a heartbeat/keepalive signal. Without a guard, the fallback dict(None) raises TypeError and kills the stream for a non-event — the client sees a 500 mid-stream instead of a seamless continuation. Add an explicit None check at the top of _chunk_to_dict returning an empty dict. The streaming loop already handles empty dicts gracefully (no _orca_meta, no usage, no model — yields a harmless empty frame).
![orcacode-review[bot]](https://avatars.githubusercontent.com/in/4254738?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 298 calls · 12.3M tokens · 98% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
Some LiteLLM stream wrappers yield
Noneas a heartbeat/keepalive signal between real chunks. Without a guard, the fallbackdict(None)in_chunk_to_dictraisesTypeError: cannot convert NoneType object to dict iteration, which propagates through the streamingtry/except Exceptionblock and kills the stream mid-flight — the client sees a 500 error frame instead of a seamless continuation.Fix: add an explicit
Nonecheck at the top of_chunk_to_dictreturning{}. The streaming loop already handles empty dicts gracefully (no_orca_meta, nousage, nomodel— yields a harmless empty SSE frame that clients ignore).Tests:
tests/unit/test_chunk_to_dict_guard.py— covers None, dict passthrough, Pydantic model, and iterable fallback paths.