Conversation
When _log_pre_stream_failure fails to commit the request log row, the request-scoped session is left in a dirty state with the pending INSERT still attached. The next DB operation on that session then fails with InvalidRequestError — a secondary failure caused by our own error handling, not the original upstream error. Add a rollback in the except clause so the session is clean for any subsequent operations (streaming _finalize, blocking path commit).
![orcacode-review[bot]](https://avatars.githubusercontent.com/in/4254738?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 376 calls · 22.8M tokens · 98% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
When
_log_pre_stream_failurefails to commit the request log row (e.g. transient SQLite busy error), the request-scoped session is left dirty with the pending INSERT still attached. Any subsequent DB operation on that session then fails withInvalidRequestError— a secondary failure caused by our own error handling, not the original upstream error.The streaming
_finalizepath already handles this correctly (its_commit_rowdoesrollbackon failure), but the pre-stream path was missing the same guard.Fix: add
await db.rollback()in the except clause so the session is clean for any subsequent operations (streaming_finalize, blocking path commit).Files changed:
app/routes/chat.py— rollback in_log_pre_stream_failureexcept clausetests/unit/test_pre_stream_rollback.py— regression test