Conversation
The OpenAI wire format accepts stop as either a string or a list of strings. "stop": "foo" and "stop": ["foo"] produce identical upstream behavior, but the cache key used the raw value — so the two forms produced different SHA-256 digests and fragmented the cache. Normalize stop to a list form in the cache key payload so string and single-element-list forms share the same cache entry.
![orcacode-review[bot]](https://avatars.githubusercontent.com/in/4254738?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 411 calls · 26M tokens · 98% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
The OpenAI wire format accepts
stopas either a string or a list of strings."stop": "foo"and"stop": ["foo"]produce identical upstream behavior, but the cache key used the raw value — so the two forms produced different SHA-256 digests and fragmented the cache.A client sending
stopas a string would always MISS when an earlier client had already warmed the cache with the list form (or vice versa).Fix: normalize
stopto list form ([stop]whenisinstance(stop, str)) in the cache key payload so both wire forms hash to the same key.Tests:
tests/unit/test_cache_stop_normalization.py— verifies string vs list equivalence, list ordering, and stability across calls.