-
Notifications
You must be signed in to change notification settings - Fork 100
Add postcard sending #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add postcard sending #8107
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5190d12
Add postcard sending
aapeliv 5336660
Add postcard service tests and MyPostcard API collection
aapeliv a96e398
Fix mypy errors in postcard service
aapeliv 4f62aa8
Use static postcard front image and simplify service
aapeliv 94ef9a0
Iterate on postcard sending
aapeliv b1599eb
Update tests
aapeliv a959b5c
Fix tests and align with repo conventions
aapeliv 8652bd3
Fix failing tests: handle process_job exception and fix mock strategy
aapeliv ba51f61
Clean up postcard verification: add sentry module, use int job_id, in…
aapeliv d6c572c
Fix indentation error and import sorting from CI failures
aapeliv 3f04860
Bump migration to 0141 after rebase onto develop
aapeliv 666cf49
Rename country to country_code in postal verification model
aapeliv 4d6d7ca
Move country→country_code rename from 0118 to 0141 migration
aapeliv 3732474
Add postcard image generation test and CI artifact upload
aapeliv b1b84e7
Remove hardcoded QR version=1, let library auto-detect
aapeliv 1c87024
Clean up postcard generation: hardcode font size, inline variables, c…
aapeliv 71a72d4
Rename country to country_code in postal verification proto and use U…
aapeliv d70b981
Clean up
aapeliv 5840b3c
Address review comments
aapeliv 1abcc8d
Address review comments
aapeliv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,3 +16,6 @@ src/proto | |
| # coverage reports | ||
| .coverage | ||
| htmlcov/ | ||
|
|
||
| # test artifacts | ||
| test_artifacts/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
|
aapeliv marked this conversation as resolved.
aapeliv marked this conversation as resolved.
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "back_left": { | ||
| "qr_left": 222, | ||
| "qr_top": 414, | ||
| "qr_size": 322, | ||
| "code_center_x": 383, | ||
| "code_center_y": 801, | ||
| "code_font_size": 58 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
app/backend/src/couchers/migrations/versions/0142_add_mypostcard_job_id.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| """Add mypostcard_job_id and rename country to country_code in postal_verification_attempts | ||
|
|
||
| Revision ID: 0142 | ||
| Revises: 0141 | ||
| Create Date: 2026-03-18 12:00:00.000000 | ||
|
|
||
| """ | ||
|
|
||
| import sqlalchemy as sa | ||
| from alembic import op | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = "0142" | ||
| down_revision = "0141" | ||
| branch_labels = None | ||
| depends_on = None | ||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| op.add_column("postal_verification_attempts", sa.Column("mypostcard_job_id", sa.Integer(), nullable=True)) | ||
| op.alter_column("postal_verification_attempts", "country", new_column_name="country_code") | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| op.alter_column("postal_verification_attempts", "country_code", new_column_name="country") | ||
| op.drop_column("postal_verification_attempts", "mypostcard_job_id") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.