Skip to content

I18n: Pluralize remaining unpluralizable strings - #8112

Merged
tristanlabelle merged 1 commit into
developfrom
i18n/pluralize-remaining
Mar 23, 2026
Merged

I18n: Pluralize remaining unpluralizable strings#8112
tristanlabelle merged 1 commit into
developfrom
i18n/pluralize-remaining

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

These were the last few placeholder numbers that didn't support pluralization. Two reasons to pluralize them:

  • Pluralization isn't just for 1 vs many, in some languages a number ending with 2 like 102 will have a different plural form than a number ending in 6 like 106, similar to English's 102nd vs 106th.
  • All strings now provide the right example for adding future strings.

I changed the keys because the placeholder's name changed, so we can't reuse existing translations.

I also changed the "65k+" placeholder in favor of formatting the 65000 number because "65k+" is not localized. I assume we're not too concerned about that code path, which implies a backend bug.

Testing

image image image

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented Mar 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview Mar 16, 2026 1:46am

Request Review

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing!

@tristanlabelle
tristanlabelle merged commit 2562748 into develop Mar 23, 2026
12 checks passed
@tristanlabelle
tristanlabelle deleted the i18n/pluralize-remaining branch March 23, 2026 02:58
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR mainly updates localization/pluralization handling for existing UI and error strings, plus documentation. While it improves translation quality in some languages, it is a minor internationalization/internal text change rather than a significant end-user feature, major UX improvement, important bug fix, or major technical infrastructure change.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR mainly updates localization/pluralization handling for existing UI and error strings, plus documentation. While it improves translation quality in some languages, it is a minor internationalization/internal text change rather than a significant end-user feature, major UX improvement, important bug fix, or major technical infrastructure change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants