Frontend/protobuf: Fix typing of [u]int64 types#8114
Closed
tristanlabelle wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@tristanlabelle Same here is this still in progress? |
Contributor
Author
|
@nabramow Still on my backlog but I can find the PR back via the issue so I can close for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our protobuf typescript definitions used the
numbertype for protobuf[u]int64fields, but at runtime they were actually javascriptstrings(because the javascriptnumbertype is a double-precision floating point that cannot represent all uint64's).Before:
After:
Surprisingly, running
yarn lintdidn't find typing issues after this change. I suspect our code often coalesced values tostring.Fixes #8113
Testing
Regenerated protos, ran the frontend and clicked around. Validated the member count still shows properly. I imagine this would crash very fast if it was wrong.
Web frontend checklist
For maintainers