Skip to content

Frontend/i18n: Move monthFormatter to localizeDateTime infra.#8123

Merged
tristanlabelle merged 4 commits into
developfrom
frontend/refactor/monthFormatter
Mar 23, 2026
Merged

Frontend/i18n: Move monthFormatter to localizeDateTime infra.#8123
tristanlabelle merged 4 commits into
developfrom
frontend/refactor/monthFormatter

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Aligns formatting months with the design for formatting other dates, so they all have the same parameters. Will also support using the caching from #8122

localizeDateTime can be used directly, but I also added a localizeYearMonth helper.

Assumes changes from #8124 , so please also review :)

Testing

Ran frontend locally

image

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview Mar 23, 2026 11:42am

Request Review

Comment thread app/web/utils/date.ts Outdated
@tristanlabelle
tristanlabelle marked this pull request as ready for review March 18, 2026 08:57
@tristanlabelle
tristanlabelle requested review from a team and aapeliv March 18, 2026 08:58

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll let Nicole look at this!

nabramow
nabramow previously approved these changes Mar 23, 2026

@nabramow nabramow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Switched around a bunch of languages in ReferenceListItem and the AboutMe and all looked okay.

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

@nabramow Thanks for the review and testing. I did a tiny change to merge with my other PR so I'll need reapproval: 0051570

@nabramow
nabramow self-requested a review March 23, 2026 14:37
@tristanlabelle
tristanlabelle merged commit 26fdd91 into develop Mar 23, 2026
9 checks passed
@tristanlabelle
tristanlabelle deleted the frontend/refactor/monthFormatter branch March 23, 2026 14:38
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR is mainly an internal frontend i18n/date-formatting refactor that consolidates month formatting into existing localization infrastructure. It does not introduce a clear new feature, major UX change, or important user-facing bug fix, and any visible impact appears minor and mostly about implementation consistency.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR is mainly an internal frontend i18n/date-formatting refactor that consolidates month formatting into existing localization infrastructure. It does not introduce a clear new feature, major UX change, or important user-facing bug fix, and any visible impact appears minor and mostly about implementation consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants