Events/i18n: Remove start/end display times from protos - #8457
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aapeliv
left a comment
There was a problem hiding this comment.
lgtm but i think you got the proto syntax a bit wrong
|
@aapeliv Fixed the protobuf syntax error. |
aapeliv
left a comment
There was a problem hiding this comment.
lgtm, thanks for the cleanup!
📝 Release NotesThis PR does not need to be included in release notes. Reason: This PR removes unused backend protobuf fields for event time display and shifts localization responsibility to the frontend. It is described as dead code cleanup, with no new user-facing feature, noticeable UX change, or significant platform-level technical improvement called out for end users. 🤖 Bot Debug InformationModel: |
Localization of datetimes should happen on the frontend, which can decide what format to use based on the context (e.g. abbreviated months, weekdays or not). The backend-provided time display value was not localized properly and unused. Better just remove it.
Testing
This was dead code. Tests should cover regressions.
Backend checklist
developif necessary for linear migration historyWeb frontend checklist
For maintainers