Skip to content

Events/i18n: Remove start/end display times from protos - #8457

Merged
tristanlabelle merged 3 commits into
developfrom
tristan/refactor/remove-protos-event-display-time
May 10, 2026
Merged

Events/i18n: Remove start/end display times from protos#8457
tristanlabelle merged 3 commits into
developfrom
tristan/refactor/remove-protos-event-display-time

Conversation

@tristanlabelle

Copy link
Copy Markdown
Contributor

Localization of datetimes should happen on the frontend, which can decide what format to use based on the context (e.g. abbreviated months, weekdays or not). The backend-provided time display value was not localized properly and unused. Better just remove it.

Testing

This was dead code. Tests should cover regressions.

Backend checklist

  • Added tests for any new code or added a regression test if fixing a bug
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 7, 2026 5:48am

Request Review

@tristanlabelle
tristanlabelle marked this pull request as ready for review May 5, 2026 11:46
@tristanlabelle
tristanlabelle requested review from a team and WouldYouKindly May 5, 2026 11:46

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but i think you got the proto syntax a bit wrong

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

@aapeliv Fixed the protobuf syntax error.

@aapeliv aapeliv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the cleanup!

@tristanlabelle
tristanlabelle merged commit f31fba7 into develop May 10, 2026
6 checks passed
@tristanlabelle
tristanlabelle deleted the tristan/refactor/remove-protos-event-display-time branch May 10, 2026 05:38
@github-actions

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR removes unused backend protobuf fields for event time display and shifts localization responsibility to the frontend. It is described as dead code cleanup, with no new user-facing feature, noticeable UX change, or significant platform-level technical improvement called out for end users.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR removes unused backend protobuf fields for event time display and shifts localization responsibility to the frontend. It is described as dead code cleanup, with no new user-facing feature, noticeable UX change, or significant platform-level technical improvement called out for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants